CLN/PERF: Do not import matplotlib at the module level. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self: Matplotlib is still being imported by pims, which is imported by trackpy. Will fix it over there next.... |
|
To be clear, walkthrough here means 'show me progress of my refinement', not the walk-through tutorial? |
|
@tacaswell Yes. |
|
I think it would be better to have |
tacaswell
added a commit
that referenced
this pull request
Jul 5, 2014
CLN/PERF: Do not import matplotlib at the module level.
danielballan
added a commit
to danielballan/trackpy
that referenced
this pull request
Jul 8, 2014
danielballan
added a commit
that referenced
this pull request
Jul 8, 2014
FIX: Fix typo introducing in #112 mpl cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106.
Now, following best practice, matplotlib is never imported outside of a function. It will only be imported if one of the functions in
plotsis called, or iflocateis used withwalkthrough=True(which is not the default).@RebeccaWPerry You will have to rebase #104 on this.