Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: read config from .blurhash-maprc.js file #16

Merged
merged 1 commit into from
Apr 3, 2024
Merged

feat: read config from .blurhash-maprc.js file #16

merged 1 commit into from
Apr 3, 2024

Conversation

softberry
Copy link
Owner

@softberry softberry commented Apr 3, 2024 •
edited
Loading

Description of change

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@softberry softberry merged commit e7cd3d7 into main Apr 3, 2024
1 check passed
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 3, 2024
View reviewed changes
src/blur-hash-map.ts
writeFileSync(imageHashFile, hash);
console.log(`✅ ${this.getShortPath(imageHashFile)} has been created\n`);
const execCommand = `${this.executable} ${this.config.components.x} ${this.config.components.y} "${imageFilePath}"`;
const hash = execSync(execCommand);

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
Loading
.
src/blur-hash-map.ts
const hash = execSync(execCommand).toString();
writeFileSync(imageHashFile, hash);
console.log(`✅ ${this.getShortPath(imageHashFile)} has been created\n`);
const execCommand = `${this.executable} ${this.config.components.x} ${this.config.components.y} "${imageFilePath}"`;

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This string concatenation which depends on
library input
Loading
is later used in a
shell command
Loading
.
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@softberry