Skip to content

Update pylint to version 1.7 #818

@allmightyspiff

Description

@allmightyspiff

tox.ini has pylint pinned to 1.6.5.
Upgrade to 1.7 will require some code changes.

GLOB sdist-make: /Users/christopher/Code/softlayer-python/setup.py
analysis inst-nodeps: /Users/christopher/Code/softlayer-python/.tox/dist/SoftLayer-5.2.3.zip
analysis installed: alabaster==0.7.10,astroid==1.5.2,Babel==2.4.0,backports.functools-lru-cache==1.3,click==6.7,configparser==3.5.0,coverage==4.3.4,docutils==0.13.1,enum34==1.1.6,extras==1.0.0,fixtures==3.0.0,flake8==2.5.5,funcsigs==1.0.2,hacking==0.13.0,imagesize==0.7.1,isort==4.2.5,Jinja2==2.9.6,lazy-object-proxy==1.2.2,linecache2==1.0.0,MarkupSafe==1.0,mccabe==0.2.1,mock==2.0.0,pbr==3.0.0,pep8==1.5.7,pluggy==0.4.0,prettytable==0.7.2,prompt-toolkit==1.0.14,py==1.4.33,pyflakes==0.8.1,Pygments==2.2.0,pylint==1.7.1,pytest==3.0.7,pytest-cov==2.4.0,python-mimeparse==1.6.0,pytz==2017.2,requests==2.13.0,singledispatch==3.4.0.3,six==1.10.0,snowballstemmer==1.2.1,SoftLayer==5.2.3,Sphinx==1.5.5,testtools==2.2.0,tox==2.7.0,traceback2==1.4.0,unittest2==1.1.0,virtualenv==15.1.0,wcwidth==0.1.7,wheel==0.24.0,wrapt==1.10.10
analysis runtests: PYTHONHASHSEED='107175304'
analysis runtests: commands[0] | flake8 SoftLayer tests
analysis runtests: commands[1] | pylint SoftLayer -r n --ignore=tests,fixtures -d too-many-locals -d star-args -d redefined-variable-type -d locally-disabled --max-args=20 --max-branches=20 --max-statements=60 --min-public-methods=0 --min-similarity-lines=30
************* Module SoftLayer.transports
R:174,12: Unnecessary "else" after "return" (no-else-return)
R:307,12: Unnecessary "else" after "return" (no-else-return)
************* Module SoftLayer.CLI.core
W: 54, 4: Parameters differ from overridden 'get_command' method (arguments-differ)
C: 60,11: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
R: 66, 8: Unnecessary "else" after "return" (no-else-return)
************* Module SoftLayer.CLI.formatting
R: 66, 7: Consider merging these isinstance calls to isinstance(data, (list, tuple)) (consider-merging-isinstance)
W:246, 4: Parameters differ from overridden 'default' method (arguments-differ)
C:262,11: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
************* Module SoftLayer.CLI.helpers
C: 41, 7: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
************* Module SoftLayer.CLI.template
R: 33,17: Redefining argument with the local name 'value' (redefined-argument-from-local)
************* Module SoftLayer.CLI.config.setup
C: 38,11: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
************* Module SoftLayer.CLI.dns.record_list
R: 40, 8: Redefining argument with the local name 'record' (redefined-argument-from-local)
************* Module SoftLayer.CLI.loadbal.service_add
C: 43,11: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
************* Module SoftLayer.CLI.virt.create
C: 40,32: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
************* Module SoftLayer.managers.hardware
R:279, 8: Unnecessary "else" after "return" (no-else-return)
************* Module SoftLayer.managers.messaging
R:292, 8: Unnecessary "else" after "return" (no-else-return)
************* Module SoftLayer.managers.metadata
C:115,11: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
************* Module SoftLayer.managers.network
R:124, 8: Unnecessary "else" after "return" (no-else-return)
************* Module SoftLayer.managers.ordering
R: 97, 8: Unnecessary "else" after "return" (no-else-return)
C: 97,11: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
R:220, 8: Unnecessary "else" after "return" (no-else-return)
C:220,11: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
************* Module SoftLayer.managers.storage_utils
C: 80, 7: Do not use `len(SEQUENCE)` as condition value (len-as-condition)
************* Module SoftLayer.managers.vs
R:620, 8: Unnecessary "else" after "return" (no-else-return)
************* Module SoftLayer.testing.xmlrpc


W: 81, 4: Parameters differ from overridden 'log_message' method (arguments-differ)

-----------------------------------
Your code has been rated at 9.96/10

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions