Skip to content

#1034 - pagination for tickets #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2018
Merged

#1034 - pagination for tickets #1035

merged 3 commits into from
Sep 11, 2018

Conversation

allmightyspiff
Copy link
Member

  • Adds pagination for tickets lists
  • Adds py37 tox environment
  • Ignores depreciated warnings when running tests

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.145% when pulling e32bdfa on allmightyspiff:1034 into 1d65b44 on softlayer:master.

@allmightyspiff
Copy link
Member Author

Fix for #1034

@acamacho82 acamacho82 self-assigned this Sep 11, 2018
acamacho82
acamacho82 approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@acamacho82 acamacho82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was pretty easy to add the pagination, I liked that

@allmightyspiff allmightyspiff merged commit 86d658b into softlayer:master Sep 11, 2018
@allmightyspiff allmightyspiff deleted the 1034 branch August 31, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@acamacho82 acamacho82 acamacho82 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@acamacho82 acamacho82

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@allmightyspiff @coveralls @acamacho82