New methods in DNS manager #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating my fork
…s creation of all kind of records, including ptr
…al was removed since it will never be executed
allmightyspiff
requested changes
Sep 13, 2018
SoftLayer/CLI/dns/record_add.py
Outdated
| manager = SoftLayer.DNSManager(env.client) | ||
| zone_id = helpers.resolve_id(manager.resolve_ids, zone, name='zone') | ||
| manager.create_record(zone_id, record, type, data, ttl=ttl) | ||
| type = type.upper() |
There was a problem hiding this comment.
type is a built in function of python, use zone_type or something similar instead.
I know it was already type, but now is a good time to fix that I think.
|
Agree, I changed type by record_type :D |
allmightyspiff
approved these changes
Sep 18, 2018
allmightyspiff
added a commit
that referenced
this pull request
Oct 3, 2018
v5.5.3 + Added `slcli user delete` + #1023 Added `slcli order quote` to let users create a quote from the slcli. + #1032 Fixed vs upgrades when using flavors. + #1034 Added pagination to ticket list commands + #1037 Fixed DNS manager to be more flexible and support more zone types. + #1044 Pinned Click library version at >=5 < 7
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new methods allows to create MX, SRV and PTR records.
The CLI supports the creation of A, AAAA, MX, TXT, SPF, SRV, CNAME, and PTR records, it should fix the issue #584