Fix unit tests #1048
Merged
Fix unit tests #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allmightyspiff
approved these changes
Oct 3, 2018
There was a problem hiding this comment.
I likely need to write a policy for data in fixtures, but really the only thing I would want changed is your username where it appears, and maybe any accountIds.
Data that exists across accounts, like router or datacenter ids, are find to keep the real values for.
Using softlayer.com is also fine for domain names, but so is test.com.
Once the tests pass, I'll merge this.
|
I agree there probably needs to be a policy in place for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.