#1074 - fixed issue with config setup

[allmightyspiff]

slcli config setup would error out if the endpoint you selected was not xmlrpc, or if you had an exiting endpoint that was REST and picked xmlrpc.

This change should fix that.

fixes #1074

[acamacho82]

I couldn't reproduce the errors reported before but it seems that not all commands work as with the XMLRPC endpoint, for example:

REST:

$ slcli image list --private
:....:......:......:............:.........:
: id : name : type : visibility : account :
:....:......:......:............:.........:
:....:......:......:............:.........:

XMLRPC:

$ slcli image list --private
:.........:...............................................:...........:............:.........:
:    id   :                      name                     :    type   : visibility : account :
:.........:...............................................:...........:............:.........:
: 11111111:                AJCB-TESTIMPO01                : ISO Image :  Private   : ####### :
: 2222222 :           AJCB-VSI54786469-localdisk          :   System  :  Private   : ####### :
: 3333333 :              Ajcb0Image1111111111             :   System  :  Private   : ####### :
: 3333333 :                Ajcb0Image2A2A2A               :   System  :  Private   : ####### :
: 4444444 :               Ajcb0Image3D3D3D3D              :    None   :  Private   : ####### :
: 5555555 :                  testTemplate                 :   System  :  Private   : ####### :
:.........:...............................................:...........:............:.........:

[allmightyspiff]

To generate this error, on the master branch, your config needs to have the rest endpoint set.

(py3) ~/Code/softlayer-python>> master $> grep -i "^endpoint" ~/.softlayer
endpoint_url = https://api.softlayer.com/rest/v3.1/
 (py3) ~/Code/softlayer-python>>maste $> ./slcli config setup
Username [myusername]:
API Key or Password [myapikeyhere]:
Endpoint (public|private|custom) [public]:
Timeout [60.0]:
An unexpected error has occured:
Traceback (most recent call last):
  File "/Users/christopher/Code/softlayer-python/SoftLayer/CLI/core.py", line 182, in main
    cli.main(**kwargs)
  File "/Users/christopher/.virtualenvs/py3/lib/python3.7/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/Users/christopher/.virtualenvs/py3/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/christopher/.virtualenvs/py3/lib/python3.7/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/christopher/.virtualenvs/py3/lib/python3.7/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/christopher/.virtualenvs/py3/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/Users/christopher/.virtualenvs/py3/lib/python3.7/site-packages/click/decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/Users/christopher/.virtualenvs/py3/lib/python3.7/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/Users/christopher/Code/softlayer-python/SoftLayer/CLI/config/setup.py", line 52, in cli
    api_key = get_api_key(env.client, username, secret)
  File "/Users/christopher/Code/softlayer-python/SoftLayer/CLI/config/setup.py", line 26, in get_api_key
    client['Account'].getCurrentUser()
  File "/Users/christopher/Code/softlayer-python/SoftLayer/API.py", line 387, in call_handler
    return self(name, *args, **kwargs)
  File "/Users/christopher/Code/softlayer-python/SoftLayer/API.py", line 355, in call
    return self.client.call(self.name, name, *args, **kwargs)
  File "/Users/christopher/Code/softlayer-python/SoftLayer/API.py", line 263, in call
    return self.transport(request)
  File "/Users/christopher/Code/softlayer-python/SoftLayer/transports.py", line 436, in __call__
    call.result = self.transport(call)
  File "/Users/christopher/Code/softlayer-python/SoftLayer/transports.py", line 382, in __call__
    result = json.loads(resp.text)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Feel free to report this error as it is likely a bug:
    https://github.com/softlayer/softlayer-python/issues
The following snippet should be able to reproduce the error

slcli image list is already something known to not work with rest: #962, even though it does get data back...

[acamacho82]

sorry, I wanted to say I tested your fix and I couldn't reproduce that errors again. I think this can be merged once the failed unittest has been fixed

[coveralls]

Coverage increased (+0.006%) to 89.846% when pulling 5dc451f on allmightyspiff:1074 into 42cd438 on softlayer:master.