Skip to content

#676 - ipv6 support for creating virtual guests #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 2, 2019
Merged

#676 - ipv6 support for creating virtual guests #1087

merged 10 commits into from
Jan 2, 2019

Conversation

allmightyspiff
Copy link
Member

@allmightyspiff allmightyspiff commented Dec 6, 2018 •
edited
Loading

Refactored slcli vs create to use SoftLayer_Product_Order::placeOrder instead of SoftLayer_Virtual_Guest::createObject so that VSIs can be ordered with ipv6.

Fixes #676

@allmightyspiff allmightyspiff requested a review from ATGE December 6, 2018 22:49
ATGE
ATGE reviewed Dec 7, 2018
View reviewed changes
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

acamacho82
acamacho82 reviewed Dec 7, 2018
View reviewed changes
Copy link
Contributor

@acamacho82 acamacho82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to mix all options and I can only see that --userdata is broken and the prompt message was removed.

@coveralls
Copy link

coveralls commented Dec 8, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 90.1% when pulling 0b94a90 on allmightyspiff:676 into 08ca596 on softlayer:master.

@allmightyspiff allmightyspiff self-assigned this Dec 12, 2018
@allmightyspiff allmightyspiff merged commit e478f1d into softlayer:master Jan 2, 2019
@allmightyspiff allmightyspiff deleted the 676 branch August 31, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FernandoOjeda FernandoOjeda Awaiting requested review from FernandoOjeda

2 more reviewers

@ATGE ATGE ATGE left review comments

@acamacho82 acamacho82 acamacho82 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@allmightyspiff allmightyspiff

Labels

CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@allmightyspiff @coveralls @acamacho82 @ATGE