Skip to content

Issue 962 - Rest Transport improvements #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 4, 2019
Merged

Issue 962 - Rest Transport improvements #1094

merged 14 commits into from
Feb 4, 2019

Conversation

erick-sapp
Copy link
Contributor

This adds some extra exception handling, and updates sections for updates to tox/pylint.

@coveralls
Copy link

coveralls commented Jan 31, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 90.456% when pulling 5e6d45f on erick-sapp:dev into d047447 on softlayer:master.

@allmightyspiff allmightyspiff self-requested a review January 31, 2019 22:25
@allmightyspiff allmightyspiff added the Core Issues dealing with core functionality label Jan 31, 2019
@allmightyspiff allmightyspiff changed the title Issue 962 Issue 962 - Rest Transport improvements Jan 31, 2019
@erick-sapp
Copy link
Contributor Author

I added some extra exception handling that I had missed, and added unit tests to cover each possible error.

@erick-sapp
Copy link
Contributor Author

Now that everything seems clear, I will merge this in now.

@erick-sapp erick-sapp merged commit 27c9c6f into softlayer:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

Assignees

@erick-sapp erick-sapp

Labels
Core Issues dealing with core functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erick-sapp @coveralls @allmightyspiff