Skip to content

#1089 removed legacy SL message queue commands #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 27, 2019
Merged

#1089 removed legacy SL message queue commands #1105

merged 2 commits into from
Feb 27, 2019

Conversation

allmightyspiff
Copy link
Member

removes the following commands

  • messaging accounts-list
  • messaging endpoints-list
  • messaging ping
  • messaging queue-add
  • messaging queue-detail
  • messaging queue-edit
  • messaging queue-list
  • messaging queue-pop
  • messaging queue-push
  • messaging queue-remove
  • messaging topic-add
  • messaging topic-detail
  • messaging topic-list
  • messaging topic-push
  • messaging topic-remove
  • messaging topic-subscribe
  • messaging topic-unsubscribe

@allmightyspiff allmightyspiff self-assigned this Feb 21, 2019
@coveralls
Copy link

coveralls commented Feb 21, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 91.676% when pulling 8ef829c on allmightyspiff:1089 into c0553f4 on softlayer:master.

ATGE
ATGE suggested changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On docs, there are still some references to deleted files:
softlayer-python/docs/cli.rst
softlayer-python/docs/api/managers/messaging.rst

acamacho82
acamacho82 approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@acamacho82 acamacho82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, at least I could not find any other place which still has this feature

@allmightyspiff
Copy link
Member Author

@ATGE thanks good catch on the docs.

@allmightyspiff allmightyspiff merged commit ae19bc2 into softlayer:master Feb 27, 2019
@allmightyspiff allmightyspiff deleted the 1089 branch August 31, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoOjeda FernandoOjeda Awaiting requested review from FernandoOjeda

2 more reviewers

@ATGE ATGE ATGE requested changes

@acamacho82 acamacho82 acamacho82 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@allmightyspiff allmightyspiff

Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@allmightyspiff @coveralls @acamacho82 @ATGE