Skip to content

Conversation

acamacho82
Copy link
Contributor

@acamacho82 acamacho82 commented Mar 1, 2019

try/catch was added to handle json decode errors in the --extras value, it should fix #1107

slcli order place and slcli order place-quote

output python 2.7:
There was an error when parsing the --extras value: No JSON object could be decoded

output python 3:
There was an error when parsing the --extras value: Expecting value: line 1 column 28 (char 27)

@acamacho82 acamacho82 self-assigned this Mar 1, 2019
@coveralls
Copy link

coveralls commented Mar 1, 2019

Coverage Status

Coverage increased (+0.03%) to 91.701% when pulling b00f68b on acamacho82:1107 into ae19bc2 on softlayer:master.

@allmightyspiff allmightyspiff merged commit 3f5e873 into softlayer:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better json parsing in ordering
3 participants