Skip to content

Invoice and event CLI #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 27, 2019
Merged

Invoice and event CLI #1120

merged 12 commits into from
Mar 27, 2019

Conversation

allmightyspiff
Copy link
Member

New Commands

  • account events
  • account event-detail
  • account invoices
  • account invoice-detail
  • account summary

New Manager

  • account

@allmightyspiff allmightyspiff self-assigned this Mar 21, 2019
@coveralls
Copy link

coveralls commented Mar 21, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 91.829% when pulling 843f531 on allmightyspiff:billing into 428753b on softlayer:master.

acamacho82
acamacho82 suggested changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@acamacho82 acamacho82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some minor issues, on the other hand, the code looks great!

acamacho82
acamacho82 reviewed Mar 22, 2019
View reviewed changes
FernandoOjeda
FernandoOjeda reviewed Mar 22, 2019
View reviewed changes
Copy link
Contributor

@FernandoOjeda FernandoOjeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good!! I only made some recommendations.

ATGE
ATGE suggested changes Mar 22, 2019
View reviewed changes
@allmightyspiff allmightyspiff merged commit 0c21f70 into softlayer:master Mar 27, 2019
@allmightyspiff allmightyspiff deleted the billing branch March 27, 2019 20:04
This was referenced Mar 27, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@acamacho82 acamacho82 acamacho82 approved these changes

@ATGE ATGE ATGE approved these changes

@FernandoOjeda FernandoOjeda FernandoOjeda approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@allmightyspiff allmightyspiff

Labels
CLI New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@allmightyspiff @coveralls @acamacho82 @ATGE @FernandoOjeda