-
Notifications
You must be signed in to change notification settings - Fork 194
Issues1100 - Event Log Improvements #1125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update branch.
Finishfish
…into erick-sapp-dev
100% coverage on event_log, so I'm going to ignore the -0.06% coverage decrease, mostly due to there being less lines overall.
|
Biggest change here is support for limit in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but I found that --limit=-1 prints only 1 event instead of ALL events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good.
#1100
Changes to the
slcli event-log get
command to better support pagination.Since this command takes 20-40s to return, I went with directly outputting the results with a generator so users can constantly see updates if they request a lot of items. Sadly PrettyTable doesn't really support that behavior.