#1221 Added version checker #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why that pypy3.5 test is failing, I'll have to figure that out. |
allmightyspiff
requested changes
Feb 11, 2020
SoftLayer/CLI/core.py
Outdated
| import time | ||
| import traceback | ||
| import types | ||
| import urllib3 |
There was a problem hiding this comment.
use requests, which contains its own json stuff, so you can remove the json import as well.
And add this constant:
PROG_NAME = "slcli (SoftLayer Command-line)"
SoftLayer/CLI/core.py
Outdated
| return latest | ||
|
|
||
|
|
||
| def get_version_message(): |
There was a problem hiding this comment.
This will actually call get_latest_version() for EVERY command run. So lets do the following:
def get_version_message(ctx, param, value):
if not value or ctx.resilient_parsing:
return
current = SoftLayer.consts.VERSION
latest = get_latest_version()
click.secho("Current: {prog} {current}\nLatest: {prog} v{latest}".format(
prog=PROG_NAME, current=current, latest=latest))
ctx.exit()
SoftLayer/CLI/core.py
Outdated
| required=False, | ||
| help="Use demo data instead of actually making API calls") | ||
| @click.version_option(prog_name="slcli (SoftLayer Command-line)") | ||
| @click.version_option(prog_name="slcli (SoftLayer Command-line)", |
There was a problem hiding this comment.
Doing this will allow us to only query for the latest version only when someone actually runs --version.
@click.option('--version', is_flag=True, expose_value=False, is_eager=True, callback=get_version,
help="Show version information.")
allmightyspiff
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.