Issue1234 #1245
Merged
Issue1234 #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allmightyspiff
requested changes
Mar 20, 2020
SoftLayer/managers/image.py
Outdated
| output_error.format(location_name, image_id) | ||
| ) | ||
|
|
||
| locations_ids.append(matching_location.get('id')) |
There was a problem hiding this comment.
I'd change this to locations_ids.append(matching_location) so that you can just pass that list directly to the API and you can remove the locations_ids = [{'id': location_id} for location_id in locations] lines in your other two functions.
SoftLayer/managers/image.py
Outdated
| :param int image_id: The ID of the image. | ||
| :param list location_names: A list of location names strings. | ||
| :returns: A list of locations IDs associated with the given location | ||
| keynames in the image id. |
SoftLayer/managers/image.py
Outdated
| break | ||
| if matching_location.get('id') is None: | ||
| raise exceptions.SoftLayerError( | ||
| output_error.format(location_name, image_id) |
SoftLayer/CLI/image/datacenter.py
Outdated
| @click.command() | ||
| @click.argument('identifier') | ||
| @click.option('--add/--remove', | ||
| default=False, |
There was a problem hiding this comment.
default to True, so the default behavior will be to add dcs, and put this on the same line as --add/--remove, help can be on its own line though.
allmightyspiff
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to set which DC an image has a copy in.