Skip to content

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Mar 24, 2020

#887

  • fixed too many newlins in tickets

@coveralls
Copy link

coveralls commented Mar 24, 2020

Coverage Status

Coverage increased (+0.003%) to 94.563% when pulling 47b03f3 on caberos:issue887 into 23a748a on softlayer:master.

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your tests are failing because in your ticket_tests you have
ticket_table = ticket.get_ticket_results(ticket_mgr, False,100)
but get_ticket_results is defined as def get_ticket_results(mgr, ticket_id, is_json, update_count=1) so your arguments are out of order. Looks like they are in the correct order in the ticket CLI module itself, so no worries there.

@allmightyspiff allmightyspiff merged commit c3dfc35 into softlayer:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SLCLI - Response shows additional new lines (\n) in ticket details
3 participants