Skip to content

Conversation

FernandoOjeda
Copy link
Contributor

@FernandoOjeda FernandoOjeda commented Mar 26, 2020

Storage feature for virtual and hardware servers #1241.

@coveralls
Copy link

coveralls commented Mar 26, 2020

Coverage Status

Coverage increased (+0.05%) to 94.518% when pulling 788b7a0 on FernandoOjeda:issue_1241 into d30a1a7 on softlayer:master.

@FernandoOjeda FernandoOjeda self-assigned this Mar 26, 2020
@FernandoOjeda FernandoOjeda removed the request for review from allmightyspiff March 26, 2020 22:29
@allmightyspiff allmightyspiff self-requested a review April 1, 2020 18:45
@allmightyspiff allmightyspiff linked an issue Apr 1, 2020 that may be closed by this pull request
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like to see the local disk storage on the vs/hw details page as well.

@FernandoOjeda
Copy link
Contributor Author

FernandoOjeda commented Apr 2, 2020

About the local disk storage do you mean these?
Virtual Server:
image

image

Hardware Server:
image

It seems that hardware server storage in this part only shows the hard drives and there is not a relational datatype for blockdevices the same that the VS.

@allmightyspiff
Copy link
Member

Yes, I want those to show up on slcli hardware|vs detail

for hardware, isn't hard_drives = hardware.get_hard_drives(hardware_id) getting the drives like in your screenshot?

@allmightyspiff
Copy link
Member

Something like this:

$ slcli hw detail 943379
id          943379
guid        31e20db3-d7b5-4492-944f-e2215670b856
hostname    host0.vmware
domain      chechu.com
fqdn        host0.vmware.chechu.com
status      ACTIVE
datacenter  fra02
cores       12
memory      262144
drives      
    Seagate Enterpries  12000GB   zxc9d78s
    Seagate Enterpries  12000GB   zxc9d722
public_ip   158.177.97.206
private_ip  10.85.94.142
ipmi_ip     10.85.94.146
os          VSphere
os_version  6.5.0u1
created     2017-12-20T12:21:42-06:00
owner       schaparro
vlans       PRIVATE  1202  2206791
            PUBLIC   1126  2206789
Bandwidth   Private  4420.03379  13813.32856  N/A
            Public   1647.15639  26.74248     500
tags        tape tool: chechu-testing, tape tool: vmware-demo-lab-chechu

@FernandoOjeda
Copy link
Contributor Author

ok sure, I will add the local disks information for both slcli hardware|vs detail, the same that your example.

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing missing is the docs\cli\hardware.rst and docs\cli\vs.rst updates for the new storage commands. Sorry I didn't mention that before.

@allmightyspiff allmightyspiff merged commit 23a748a into softlayer:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage feature for virtual and hardware servers
3 participants