Skip to content

Add prices to vs create-options. #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2020
Merged

Add prices to vs create-options. #1351

merged 3 commits into from
Oct 5, 2020

Conversation

FernandoOjeda
Copy link
Contributor

Add prices to vs create-options #1325.

@FernandoOjeda FernandoOjeda self-assigned this Sep 22, 2020
@allmightyspiff allmightyspiff added the Ordering Anything related to ordering label Sep 28, 2020
@allmightyspiff
Copy link
Member

allmightyspiff commented Sep 28, 2020 •
edited
Loading

testing

✔️ slcli -v --format=table vs create-options --prices tok02
✔️ slcli -v --format=table vs create-options --prices
✔️ slcli -v --format=table vs create-options
✔️ slcli -v --format=table vs create-options --prices --vsi-type PUBLIC_CLOUD_SERVER

allmightyspiff
allmightyspiff requested changes Sep 28, 2020
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works great, but needs a few changes to the CLI code to make it read a bit easier.

Also, I don't think the RAM/CORE/Network/Extra categories have capacity restrictions, so we can just remove those from those tables.

@allmightyspiff allmightyspiff merged commit 76a7fbf into softlayer:master Oct 5, 2020
@allmightyspiff allmightyspiff linked an issue Nov 17, 2020 that may be closed by this pull request
Refactor slcli vs create-options #1325
Closed
@allmightyspiff allmightyspiff mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

Assignees

@FernandoOjeda FernandoOjeda

Labels
Ordering Anything related to ordering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor slcli vs create-options
2 participants
@FernandoOjeda @allmightyspiff