-
Notifications
You must be signed in to change notification settings - Fork 194
New Command: slcli security
#1951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ands that name starts with other command names
@ramkishor-ch when testing this, please make sure the |
Hi @allmightyspiff, Hi @BrianSantivanez, ./slcli ssl --help ./slcli sshkey --help Can you please fix this issue. Thanks, |
Hi @ramkishor-ch, the errors you mentioned are expected because If you want to run some |
Hi @BrianSantivanez, I already knew that slcli sshkey and slcli ssl commands were moved under slcli security, but I have already discussed the same doubt on yesterday with @allmightyspiff. @allmightyspiff was told that " make sure still old commands: slcli sshkey and slcli ssl should work though that were added into slcli security because anyone using the slcli sshkey and slcli ssl still be able to use the old commands so it doesn't break their automation and if the commands DON'T exist, thats a problem that needs to be fixed ". Can you please fix the issue. Thanks, |
@BrianSantivanez There should still be an alias for Moving the commands into a single Basically just add these to ('sshkey', 'SoftLayer.CLI.sshkey'),
('sshkey:add', 'SoftLayer.CLI.security.sshkey_add:cli'),
('sshkey:remove', 'SoftLayer.CLI.security.sshkey_remove:cli'),
('sshkey:edit', 'SoftLayer.CLI.security.sshkey_edit:cli'),
('sshkey:list', 'SoftLayer.CLI.security.sshkey_list:cli'),
('sshkey:print', 'SoftLayer.CLI.security.sshkey_print:cli'),
('ssl', 'SoftLayer.CLI.ssl'),
('ssl:add', 'SoftLayer.CLI.security.cert_add:cli'),
('ssl:download', 'SoftLayer.CLI.security.cert_download:cli'),
('ssl:edit', 'SoftLayer.CLI.security.cert_edit:cli'),
('ssl:list', 'SoftLayer.CLI.security.cert_list:cli'),
('ssl:remove', 'SoftLayer.CLI.security.cert_remove:cli'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I have "tested the changes".
Approving the Pull Request.
Thanks,
Ramkishor Chaladi.
Issue: #1942
Observations:
sshkeys
andssl
features were merged intosecurity
feature, and core test were updated to work with commands names that start with other command names (securitygroup and security), before this upgrade if exists a command that starts with other command name this test fails