Skip to content

Adds verify option to create_client_from_env #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2016
Merged

Adds verify option to create_client_from_env #773

merged 2 commits into from
Sep 27, 2016

Conversation

sudorandom
Copy link
Contributor

Resolves #772

camporter
camporter approved these changes Sep 21, 2016
View reviewed changes
Copy link
Member

@camporter camporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor aside, it might be good to have a stronger warning for setting verify to false.

@sudorandom sudorandom merged commit 3aec9ec into softlayer:master Sep 27, 2016
@sudorandom sudorandom deleted the verify-when-creating-client branch September 27, 2016 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camporter camporter camporter approved these changes

Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sudorandom @camporter