Skip to content

Add volume-duplicate command for file & block storage #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 20, 2017
Merged

Add volume-duplicate command for file & block storage #830

merged 5 commits into from
Jun 20, 2017

Conversation

dpickle2
Copy link

@dpickle2 dpickle2 commented Jun 6, 2017

[This pull request is being opened now for review, but it should not be merged in yet as some work is still pending on the backend for duplication features to be fully supported.]

@storagedaemon storagedaemon mentioned this pull request Jun 6, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 84.214% when pulling e30f4d3 on dpickle2:feature/volume-duplicate into 44efd83 on softlayer:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 84.234% when pulling efe06a2 on dpickle2:feature/volume-duplicate into 44efd83 on softlayer:master.

allmightyspiff
allmightyspiff reviewed Jun 6, 2017
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. When this goes "live" I'd like to run some personal tests before merging and releasing.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 84.234% when pulling 9342eed on dpickle2:feature/volume-duplicate into 44efd83 on softlayer:master.

@allmightyspiff
Copy link
Member

Did some testing, everything seems to work properly.

@allmightyspiff allmightyspiff merged commit 7f4774c into softlayer:master Jun 20, 2017
@dpickle2 dpickle2 deleted the feature/volume-duplicate branch June 21, 2017 14:30
@allmightyspiff allmightyspiff mentioned this pull request Jul 19, 2017
Closed
@svrajput svrajput mentioned this pull request Jul 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpickle2 @coveralls @allmightyspiff