Skip to content

added some testing exceptions so pylint can run its latest versions #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2017
Merged

added some testing exceptions so pylint can run its latest versions #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SoftLayer/CLI/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from SoftLayer import consts

# pylint: disable=too-many-public-methods, broad-except, unused-argument
# pylint: disable=redefined-builtin, super-init-not-called
# pylint: disable=redefined-builtin, super-init-not-called, arguments-differ

START_TIME = time.time()
DEBUG_LOGGING_MAP = {
Expand Down
14 changes: 7 additions & 7 deletions SoftLayer/CLI/dns/record_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from SoftLayer.CLI import environment
from SoftLayer.CLI import formatting
from SoftLayer.CLI import helpers
# pylint: disable=redefined-builtin
# pylint: disable=redefined-builtin, redefined-argument-from-local


@click.command()
Expand Down Expand Up @@ -37,13 +37,13 @@ def cli(env, zone, data, record, ttl, type):
ttl=ttl,
data=data)

for record in records:
for the_record in records:
table.add_row([
record['id'],
record['host'],
record['type'].upper(),
record['ttl'],
record['data']
the_record['id'],
the_record['host'],
the_record['type'].upper(),
the_record['ttl'],
the_record['data']
])

env.fout(table)
2 changes: 1 addition & 1 deletion SoftLayer/CLI/formatting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

:license: MIT, see LICENSE for more details.
"""
# pylint: disable=E0202
# pylint: disable=E0202, consider-merging-isinstance, arguments-differ
import collections
import json
import os
Expand Down
2 changes: 2 additions & 0 deletions SoftLayer/CLI/template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

:license: MIT, see LICENSE for more details.
"""

# pylint: disable=redefined-argument-from-local
import os.path

from SoftLayer import utils
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/testing/xmlrpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from SoftLayer import transports
from SoftLayer import utils

# pylint: disable=invalid-name, broad-except
# pylint: disable=invalid-name, broad-except, arguments-differ


class TestServer(six.moves.BaseHTTPServer.HTTPServer):
Expand Down
4 changes: 3 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ basepython = python2.7
deps =
-r{toxinidir}/tools/test-requirements.txt
hacking
pylint==1.6.5
pylint
commands =
flake8 SoftLayer tests

Expand All @@ -33,6 +33,8 @@ commands =
-d star-args \
-d redefined-variable-type \
-d locally-disabled \
-d no-else-return \
-d len-as-condition \
--max-args=20 \
--max-branches=20 \
--max-statements=60 \
Expand Down