Skip to content

Check for billing before attempting to cancel a firewall. #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2017
Merged

Check for billing before attempting to cancel a firewall. #836

merged 1 commit into from
Jul 3, 2017

Conversation

camporter
Copy link
Member

This prevents an unexpected error from occurring when billing does not exist for a firewall but cancellation is attempted.

Addresses #835

@camporter
Check for billing before attempting to cancel a firewall.
12d9204 
This prevents an unexpected error from occurring when billing does not exist for a firewall but cancellation is attempted.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 84.243% when pulling 12d9204 on camporter:check_for_billing_on_firewall_cancel into 148cf05 on softlayer:master.

@allmightyspiff
Copy link
Member

thanks, looks good to me.

@allmightyspiff allmightyspiff merged commit 0045d37 into softlayer:master Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camporter @coveralls @allmightyspiff