updating the virt cli create and create-options commands #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted hosts and flavors correct sorting, removing need to methods to add cpus and flavors rows
kwienken
force-pushed
the
vs-create-updates
branch
from
2ffec97 to
73c19c1
Compare
camporter
approved these changes
Aug 24, 2017
| required = [hostname, domain] | ||
|
|
||
| flavor = kwargs.get('flavor', None) | ||
| host_id = kwargs.get('host_id', None) |
There was a problem hiding this comment.
Is it ok if flavor is provided, but host_id is also given? host_id doesn't require dedicated, so it won't hit the exclusive check.
There was a problem hiding this comment.
host_id should not be provided with flavor. I'll update to prevent that.
SoftLayer/managers/vs.py
Outdated
| 'id,nextInvoiceTotalRecurringAmount,' | ||
| 'children[categoryCode,nextInvoiceTotalRecurringAmount],' | ||
| 'orderItem.order.userRecord[username]' | ||
| 'orderItem[id,order.userRecord[username],preset.keyName]' |
There was a problem hiding this comment.
The billingItem mask could be made into a multiline string for readability.
| raise exceptions.ArgumentError( | ||
| '[-m | --memory] not allowed with [-f | --flavor]') | ||
|
|
||
| if all([args['dedicated'], args['flavor']]): |
There was a problem hiding this comment.
You could also include one for host-id and flavor right?
SoftLayer/CLI/virt/create_options.py
Outdated
| cpus = [] | ||
| for cpu_option in cpu_options: | ||
| cpus.append(str(cpu_option['template']['startCpus'])) | ||
| bal_flavors = [str(x['flavor']['keyName']) for x in result['flavors'] |
There was a problem hiding this comment.
You could put flavor extraction into a separate method and generalize it to avoid duplication here.
There was a problem hiding this comment.
+1 seems like a lot of duplication in this area
sergiocarlosmorales
approved these changes
Aug 24, 2017
…in create-options, misc code review update
camporter
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual create-options command was updated to show flavors and the dedicated host options. The virtual create command was updated to accept a flavor key and a host id.
This pull request is dependent on some minor updates to the SoftLayer API. DO NOT MERGE. Myself, @sergiocarlosmorales, or @camporter will handle merging this one at the appropriate time.