virtual detail: show dedicated host info, if applicable #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only applicable for VSIs that were created to be in a dedicated host. Provide id and name of the dedicated host where VSI is running.
flavio-fernandes
force-pushed
the
dedicated_host_details.merge
branch
from
49543f4 to
ad94609
Compare
Add test for verifying host_id attribute
flavio-fernandes
force-pushed
the
dedicated_host_details.merge
branch
from
6d01962 to
7a3af08
Compare
kwienken
approved these changes
Oct 23, 2017
allmightyspiff
requested changes
Oct 24, 2017
| dedicated_host = env.client.call('Virtual_DedicatedHost', 'getObject', | ||
| id=dedicated_host_id) | ||
| except SoftLayer.SoftLayerAPIError: | ||
| dedicated_host = {} |
There was a problem hiding this comment.
At least log an error when the API throws an exception.
From code review request. Thanks Christopher!
allmightyspiff
approved these changes
Oct 24, 2017
|
looks good, I'll merge this in the morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only applicable for VSIs that were created to be in a
dedicated host.
Provide id and name of the dedicated host where VSI is running.