Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SoftLayer/CLI/block/detail.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ def cli(env, volume_id):
table.add_row(['Capacity (GB)', "%iGB" % block_volume['capacityGb']])
table.add_row(['LUN Id', "%s" % block_volume['lunId']])

if block_volume.get('iops'):
table.add_row(['IOPs', block_volume['iops']])
if block_volume.get('provisionedIops'):
table.add_row(['IOPs', int(block_volume['provisionedIops'])])

if block_volume.get('storageTierLevel'):
table.add_row([
Expand Down
4 changes: 2 additions & 2 deletions SoftLayer/CLI/file/detail.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ def cli(env, volume_id):
else:
table.add_row(['Used Space', "%dGB" % (used_space / (1 << 30))])

if file_volume.get('iops'):
table.add_row(['IOPs', file_volume['iops']])
if file_volume.get('provisionedIops'):
table.add_row(['IOPs', int(file_volume['provisionedIops'])])

if file_volume.get('storageTierLevel'):
table.add_row([
Expand Down
5 changes: 2 additions & 3 deletions SoftLayer/managers/block.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def get_block_volume_details(self, volume_id, **kwargs):
'serviceResource.datacenter[name]',
'serviceResourceBackendIpAddress',
'storageTierLevel',
'iops',
'provisionedIops',
'lunId',
'originalVolumeName',
'originalSnapshotName',
Expand All @@ -105,8 +105,7 @@ def get_block_volume_details(self, volume_id, **kwargs):
'replicationSchedule[type[keyname]]]',
]
kwargs['mask'] = ','.join(items)
return self.client.call('Network_Storage', 'getObject',
id=volume_id, **kwargs)
return self.client.call('Network_Storage', 'getObject', id=volume_id, **kwargs)

def get_block_volume_access_list(self, volume_id, **kwargs):
"""Returns a list of authorized hosts for a specified volume.
Expand Down
2 changes: 1 addition & 1 deletion SoftLayer/managers/file.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def get_file_volume_details(self, volume_id, **kwargs):
'serviceResourceBackendIpAddress',
'fileNetworkMountAddress',
'storageTierLevel',
'iops',
'provisionedIops',
'lunId',
'originalVolumeName',
'originalSnapshotName',
Expand Down
10 changes: 4 additions & 6 deletions SoftLayer/managers/hardware.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def place_order(self, **kwargs):

See get_create_options() for valid arguments.

:param string size: server size name
:param string size: server size name or presetId
:param string hostname: server hostname
:param string domain: server domain name
:param string location: location (datacenter) name
Expand Down Expand Up @@ -748,15 +748,13 @@ def _get_location(package, location):
if region['location']['location']['name'] == location:
return region

raise SoftLayer.SoftLayerError("Could not find valid location for: '%s'"
% location)
raise SoftLayer.SoftLayerError("Could not find valid location for: '%s'" % location)


def _get_preset_id(package, size):
"""Get the preset id given the keyName of the preset."""
for preset in package['activePresets']:
if preset['keyName'] == size:
if preset['keyName'] == size or preset['id'] == size:
return preset['id']

raise SoftLayer.SoftLayerError("Could not find valid size for: '%s'"
% size)
raise SoftLayer.SoftLayerError("Could not find valid size for: '%s'" % size)
2 changes: 1 addition & 1 deletion tests/managers/block_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def test_get_block_volume_details(self):
'serviceResource.datacenter[name],'\
'serviceResourceBackendIpAddress,'\
'storageTierLevel,'\
'iops,'\
'provisionedIops,'\
'lunId,'\
'originalVolumeName,'\
'originalSnapshotName,'\
Expand Down
2 changes: 1 addition & 1 deletion tests/managers/file_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def test_get_file_volume_details(self):
'serviceResourceBackendIpAddress,'\
'fileNetworkMountAddress,'\
'storageTierLevel,'\
'iops,'\
'provisionedIops,'\
'lunId,'\
'originalVolumeName,'\
'originalSnapshotName,'\
Expand Down