Skip to content

Issues904 - issues with locationGroupId #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 16, 2018
Merged

Issues904 - issues with locationGroupId #965

merged 9 commits into from
Apr 16, 2018

Conversation

allmightyspiff
Copy link
Member

@allmightyspiff allmightyspiff commented Apr 16, 2018 •
edited
Loading

XMLRPC returns locationGroupId = '', but REST returns locationGroupId = None

  • locationGroupId now just checks for True/False since both None and '' == False
  • refactors a bit of the storage_utils manager to reduce duplicated code
  • fixed a problem with transactions not showing up on the slcli hw list page

@coveralls
Copy link

coveralls commented Apr 16, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 87.413% when pulling 5925e61 on allmightyspiff:issues904 into 5988805 on softlayer:master.

@allmightyspiff allmightyspiff merged commit fea6048 into softlayer:master Apr 16, 2018
@allmightyspiff allmightyspiff deleted the issues904 branch August 31, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@allmightyspiff @coveralls