Finished unit tests for CLI/virt/power #976
Conversation
| class ResolveIdTests(testing.TestCase): | ||
|
|
||
| def test_resolve_id_one(self): | ||
| resolver = lambda r: [12345] |
There was a problem hiding this comment.
Any specific reason for changing this from a lambda function?
There was a problem hiding this comment.
No real reason. The analysis was failing because of it though. Checking the message now, it would have been better to skip the assignment and put the lambda expression as the argument itself. That is normally how the lambda is intended to be used.
There was a problem hiding this comment.
I have replace the code with lambdas again, but removed the assignment process that it did not like. They are true anonymous functions created within the function calls.
There was a problem hiding this comment.
But in general, I just didn't want the analysis failing for another section of code.
|
Looks good to me. |
3 participants
I believe this completes the unit test / issue #975. If not, let me know if time is available.