Fixed hardware credentials issue. #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allmightyspiff
requested changes
Jun 29, 2018
| raise exceptions.SoftLayerError("No passwords found in operatingSystem") | ||
|
|
||
| for item in instance['operatingSystem']['passwords']: | ||
| table.add_row([item['username'], item['password']]) |
There was a problem hiding this comment.
instead of raising an exception, I would prefer this to just print out "None"
table.add_row([item.get('username', 'None'), item.get('password', 'None')])
.get() allows you to specify a default value to return if the item isn't found. This article explain it in a bit more detail if you are interested.
https://docs.quantifiedcode.com/python-anti-patterns/correctness/not_using_get_to_return_a_default_value_from_a_dictionary.html
allmightyspiff
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed hardware credentials issue #981