Skip to content

Issue#977 #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2018
Merged

Issue#977 #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
312e538
Adding fix for issue and validation
fmiquiza Jun 29, 2018
7e982d4
Adding unit test
fmiquiza Jun 29, 2018
e834590
Fixing -tox analysis error
fmiquiza Jun 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion SoftLayer/managers/ticket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

:license: MIT, see LICENSE for more details.
"""

from SoftLayer import utils


Expand Down Expand Up @@ -38,6 +37,8 @@ def list_tickets(self, open_status=True, closed_status=True):
call = 'getOpenTickets'
elif closed_status:
call = 'getClosedTickets'
else:
raise ValueError("open_status and closed_status cannot both be False")

return self.client.call('Account', call, mask=mask)

Expand Down
8 changes: 8 additions & 0 deletions tests/managers/ticket_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ def test_list_tickets_closed(self):
self.assertIn(result['id'], [100, 101])
self.assert_called_with('SoftLayer_Account', 'getClosedTickets')

def test_list_tickets_false(self):
exception = self.assertRaises(ValueError,
self.ticket.list_tickets,
open_status=False,
closed_status=False)

self.assertEqual('open_status and closed_status cannot both be False', str(exception))

def test_list_subjects(self):
list_expected_ids = [1001, 1002, 1003, 1004, 1005]

Expand Down