Skip to content

Conversation

msluszniak
Copy link
Member

@msluszniak msluszniak commented Jul 8, 2025

Description

Adds improved numerical module, and better testing infrastructure with tests.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improves or adds clarity to existing documentation)

Tested on

  • iOS
  • Android

Testing instructions

  • Run examples using normalization, softmax, and meanPooling
  • Run tests as describe in README.md inside tests directory

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@msluszniak msluszniak marked this pull request as draft July 8, 2025 07:22
@msluszniak msluszniak marked this pull request as ready for review July 9, 2025 17:12
@msluszniak
Copy link
Member Author

msluszniak commented Jul 10, 2025

I overzealously changed norm normalization to z-score normalization. I will fix that.

EDIT: Updated and ready for a review.

@msluszniak msluszniak mentioned this pull request Jul 10, 2025
10 tasks
@msluszniak msluszniak changed the title Improve numerical utils files and testing infastructure Improve numerical util files and testing infastructure Jul 14, 2025
Remove redundant comments.
@msluszniak
Copy link
Member Author

msluszniak commented Jul 30, 2025

After watching this talk from cppcon: https://www.youtube.com/watch?v=RjPK3HKcouA and official proposal on these features: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0479r2.html I decided to remove [[unlikely]] attributes casue I didn't perform PGO.

@msluszniak msluszniak requested a review from jakmro August 5, 2025 06:51
@msluszniak msluszniak requested a review from jakmro August 25, 2025 17:58
@msluszniak msluszniak mentioned this pull request Aug 25, 2025
11 tasks
@msluszniak msluszniak mentioned this pull request Aug 26, 2025
@msluszniak msluszniak requested a review from mkopcins August 27, 2025 15:37
Copy link
Contributor

@chmjkb chmjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, thanks! :D

@msluszniak msluszniak requested a review from chmjkb August 28, 2025 06:51
@chmjkb chmjkb merged commit 5be8a95 into software-mansion:main Aug 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants