-
Notifications
You must be signed in to change notification settings - Fork 45
Improve numerical util files and testing infastructure #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve numerical util files and testing infastructure #438
Conversation
packages/react-native-executorch/common/rnexecutorch/tests/README.md
Outdated
Show resolved
Hide resolved
I overzealously changed norm normalization to z-score normalization. I will fix that. EDIT: Updated and ready for a review. |
packages/react-native-executorch/common/rnexecutorch/tests/README.md
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/tests/NumericalTest.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/tests/NumericalTest.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/tests/NumericalTest.cpp
Outdated
Show resolved
Hide resolved
Remove redundant comments.
After watching this talk from cppcon: https://www.youtube.com/watch?v=RjPK3HKcouA and official proposal on these features: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0479r2.html I decided to remove |
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/CMakeLists.txt
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
…essing/Numerical.cpp
packages/react-native-executorch/common/rnexecutorch/tests/NumericalTest.cpp
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/tests/CMakeLists.txt
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
…essing/Numerical.cpp
packages/react-native-executorch/common/rnexecutorch/data_processing/Numerical.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, thanks! :D
Description
Adds improved numerical module, and better testing infrastructure with tests.
Type of change
Tested on
Testing instructions
normalization
,softmax
, andmeanPooling
README.md
insidetests
directoryScreenshots
Related issues
Checklist
Additional notes