-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glitches and crashes after migrating to reanimated >= 3.9 #6102
Comments
Hey! 👋 It looks like you've omitted a few important sections from the issue template. Please complete Snack or a link to a repository section. |
Hey! 👋 The issue doesn't seem to contain a minimal reproduction. Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem? |
We can confirm here that the same change was very helpful in our app. (We downgraded to 3.7.2.) A few screen transitions are still slower for us on Android than iOS (using react-native-navigation, which uses this library for its transitions) but before we were getting complete hangs/crashes and <=3.7.2 resolves that for us. We haven't had a chance yet to try making an isolated repro but wanted to at least add the data point. |
After more investigation we isolated the issue to this PR merged in 3.9:
|
## Summary Unfortunately, turns out the PR with dynamic styles #5268 introduced more problems than it solved. Thus, proposing a revert. This revert most likely fixed: - #6203 - #6102 - #6037 as well as one more not-published issue and potentially a few more. ## Notes Even if it gets approved, to be merged ONLY after @tjzel agrees with everything ## Test plan 😢 😭
The fix should be there by the next stable version (3.14.0 or next iteration of 3.13.x) |
@szydlovsky thank you. |
Description
Hello Reanimated team!
In our React Native project, we use Reanimated for different animations on multiple screens. Recently, we attempted to update to version 3.11.0 to support React Native 0.74 (as per the compatibility table). After this update, we started experiencing crashes and glitches on animations across the project.
During our investigation, we localized the issue starting from Reanimated version 3.9 by gradually upgrading Reanimated alone, version by version, and keeping all other packages unaltered (including React Native).
From our investigation, it seems crashes and glitches are more prominent in debug mode and on low-end devices (we tested with a real iPhone SE second generation). We were not able to reproduce crashes in release mode, but we were able to see the same glitches in animations (although less frequently).
NOTE: in our project we also use react-native-gesture-handler v2.16.2
Steps to reproduce
Unfortunately we currently don't have specific steps to reproduce, however I suggest:
Snack or a link to a repository
/
Reanimated version
3.11.0 (issue starts with 3.9.0)
React Native version
0.72.12
Platforms
Android, iOS
JavaScript runtime
Hermes
Workflow
React Native
Architecture
Paper (Old Architecture)
Build type
Debug app & dev bundle
Device
Real device
Device model
iPhone SE 2nd generation
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: