Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix withTiming playground Power slider visibility #6128

Merged
merged 2 commits into from
Jun 17, 2024
Merged

docs: Fix withTiming playground Power slider visibility #6128

merged 2 commits into from
Jun 17, 2024

Conversation

patrycjakalinska
Copy link
Contributor

@patrycjakalinska patrycjakalinska commented Jun 17, 2024 •
edited
Loading

This PR is related to #6126 issue.

The Power slider should be visible when easing or nestedEasing are set to poly. nestedEasing is only visible when easing is set to either in, out or inOut. So when we set easing to in, nestedEasing to poly and then set easing to brezier the Power slider will stay.

To fix that we added reset of nestedEasing value if easing is changed to something other that in, out or inOut

Before:

before.mov

After:

after.mov

@patrycjakalinska patrycjakalinska linked an issue Jun 17, 2024 that may be closed by this pull request
[DOCS] Interactive animation creator on docs site has a small bug #6126
Closed
@patrycjakalinska patrycjakalinska changed the title docs: Fix withTiming playground Power range visibility docs: Fix withTiming playground Power slider visibility Jun 17, 2024
szydlovsky
szydlovsky approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣

@patrycjakalinska patrycjakalinska added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 6947a3c Jun 17, 2024
5 of 6 checks passed
@patrycjakalinska patrycjakalinska deleted the @patrycjakalinska/withTiming-playground-fix branch June 17, 2024 13:52
This was referenced Jul 25, 2024
Open
Open
Open
Open
@tiago002pro tiago002pro mentioned this pull request Aug 5, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
@waveyboym waveyboym mentioned this pull request Aug 19, 2024
Closed
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 24, 2024
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szydlovsky szydlovsky szydlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Interactive animation creator on docs site has a small bug
2 participants
@patrycjakalinska @szydlovsky