Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Create Common Editor Dockable Tool Windows and Panes #227

Conversation

softwareantics
Copy link
Owner

@softwareantics softwareantics commented Aug 4, 2023

Description

  • Create dockable windows for the following (to be implemented) tools:
    • Project Explorer - a tool to show resources to be used by the current project/game (projects are yet to be created).
    • Scene Hierarchy - a tool to show all entities within a scene (scenes are yet to be created)
    • Properties - a tool that will show different properties depending on the context (entity components, rendering settings, etc).
    • Console - a tool that shows an errors or warnings to do with the project, code, etc.
    • Entity Systems - a tool that will allow the user to add, remove and order entity systems to be be used within a scene.
  • Created a dockable document pane to be used to display the currently loaded scene within the editor.
  • Created a ManageWindowLayoutsView and associated view model to manage applying and deleting saved layouts.
  • Created a SaveWindowLayoutView and associated view model used to save the currently setup layout to the applications roaming data.
  • Added a standard default layout that is used once a user first starts up the application.
  • Created a LayoutManager and LayoutManagerFactory that ensures we do not need to use the code-behind to handle saving and loading window layouts.
  • Ensured that the application will save it's current layout so that when the user runs the application again the layout is the same as it was once closed.

Issues to Close

Dependencies

Type of change

  • This feature is related to the epic: [EPIC] Editor #231.
  • New feature (non-breaking change which adds functionality).

How Has This Been Tested?

I provided unit tests for all testable changes. Final Code Coverage is showing 100% code coverage as I went ahead and fixed up a few areas in this PR that needed to be addressed anyways. Furthermore, I ran the editor and ensured that all tool windows could be toggled via the View > Tool Windows menu and the through the use of key bindings. I checked to make sure I could reset, save, delete and apply window layouts_. I also ensured that the last state of the window layout was used upon starting up the application.

Test Configuration:

  • Operating System: Windows 10 Home
  • Hardware: Intel i7-6700HQ @ 2.60GHz, 32GB RAM, GTX 950M
  • Toolchain: VS Community 2022 17.5.4

Example Video

2023-08-11.19-58-36.mp4

Possible Issues

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

…t someone will come to the rescue for the issue I've been having.
…'t like the idea of throwing an exception in Unload - Just create the manager whenever it is requried considering it is cached.
@softwareantics softwareantics marked this pull request as ready for review August 11, 2023 10:18
@softwareantics softwareantics merged commit fd657dd into epic/112-editor Aug 11, 2023
1 check passed
@softwareantics softwareantics deleted the feature/223-create-common-editor-dockable-tool-windows-and-panes branch August 11, 2023 14:30
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@softwareantics softwareantics changed the title [FEATURE] Create Common Editor Dockable Tool Windows and Panes ✨ Create Common Editor Dockable Tool Windows and Panes Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants