-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Create Common Editor Dockable Tool Windows and Panes #227
Merged
softwareantics
merged 47 commits into
epic/112-editor
from
feature/223-create-common-editor-dockable-tool-windows-and-panes
Aug 11, 2023
Merged
✨ Create Common Editor Dockable Tool Windows and Panes #227
softwareantics
merged 47 commits into
epic/112-editor
from
feature/223-create-common-editor-dockable-tool-windows-and-panes
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t someone will come to the rescue for the issue I've been having.
… working right now.
… they click the delete button.
…'t like the idea of throwing an exception in Unload - Just create the manager whenever it is requried considering it is cached.
This was
linked to
issues
Aug 10, 2023
CalvinWilkinson
suggested changes
Aug 11, 2023
FinalEngine.Tests/Editor/ViewModels/Docking/Panes/Mocks/MockPaneViewModel.cs
Show resolved
Hide resolved
FinalEngine.Tests/Editor/ViewModels/Docking/Tools/Mocks/MockToolViewModel.cs
Show resolved
Hide resolved
FinalEngine.Editor.Desktop/Selectors/Data/Docking/Panes/PaneTemplateSelector.cs
Outdated
Show resolved
Hide resolved
CalvinWilkinson
approved these changes
Aug 11, 2023
softwareantics
deleted the
feature/223-create-common-editor-dockable-tool-windows-and-panes
branch
August 11, 2023 14:30
This was referenced Aug 11, 2023
Merged
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
softwareantics
changed the title
[FEATURE] Create Common Editor Dockable Tool Windows and Panes
✨ Create Common Editor Dockable Tool Windows and Panes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ManageWindowLayoutsView
and associated view model to manage applying and deleting saved layouts.SaveWindowLayoutView
and associated view model used to save the currently setup layout to the applications roaming data.LayoutManager
andLayoutManagerFactory
that ensures we do not need to use the code-behind to handle saving and loading window layouts.Issues to Close
Dependencies
FinalEngine.Editor.Common
FinalEngine.Editor.Desktop
Type of change
How Has This Been Tested?
I provided unit tests for all testable changes. Final Code Coverage is showing 100% code coverage as I went ahead and fixed up a few areas in this PR that needed to be addressed anyways. Furthermore, I ran the editor and ensured that all tool windows could be toggled via the View > Tool Windows menu and the through the use of key bindings. I checked to make sure I could reset, save, delete and apply window layouts_. I also ensured that the last state of the window layout was used upon starting up the application.
Test Configuration:
Example Video
2023-08-11.19-58-36.mp4
Possible Issues
Dispatcher.ShutdownStarted
inDockView
code-behind #229LayoutName
text inTextBox
forSaveWindowLayoutView
. #232ApplicationContextTests
will sometimes fail. #233ErrorContent
inside tooltip forTextBox
. #235ManageWindowLayoutsViewModel
to manageLayoutNames
. #236Checklist:
ApplicationContextTests
will sometimes fail. #233 if all tests do not pass locally on your machine.