Skip to content

Royalties [v3.9.61] #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Sep 24, 2025
Merged

Royalties [v3.9.61] #107

merged 44 commits into from
Sep 24, 2025

Conversation

softwareengineerprogrammer
Copy link
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Sep 24, 2025 •
edited
Loading

Description

Addresses NREL#421 for SAM Economic Models

image image image image image

Testing & Verification

  1. Added new unit tests
  2. Added new example example_SAM-single-owner-PPA-4.: 50 MWe with Royalties
  3. Tested in web interface
  4. Manually tested/sanity-checked
    1. image
    2. image

TODO:

  1. CHANGELOG entry
  2. Validate that excluding Year 0 (0 revenue) is correct for calculating NPV: implementation includes Year 0 (excluding would be incorrect)
  3. FIXME incorrect calculation: 0da0340
  4. Slice based on pre-revenue (construction) years instead of hardcoding: a60199c
  5. Clarify taxes for royalties: a0d0c38
  6. Add a test for combined royalties and add-ons: a782cd7
  7. Royalties schedule (instead of fixed value)
  8. Update documentation
  9. Royalty collector economics
  10. Include annual average in GEOPHIRES OPEX (separate line item + include in total)
  11. Reconcile with fixed total OPEX

@softwareengineerprogrammer
Initial implementation of royalty rate. WIP - TODO to implement royal…
b3cf5b5 
…ty collector revenue/NPV/etc., update documentation, add more unit tests
@softwareengineerprogrammer
Add entry in SAM Economic Models docs
59b6950
@softwareengineerprogrammer
Regenerate schema (with Royalty Rate)
842a2b0
@softwareengineerprogrammer
Mark TODO remove or clarify project payback period: NREL#413
0a1dad9
@softwareengineerprogrammer
Include royalties in opex output/total opex (WIP)
f071d90
@softwareengineerprogrammer
Regenerate schema with Royalties output param
2046f90
@softwareengineerprogrammer
Assert that opex line items, including royalties, sum up to total
5cf8f45
@softwareengineerprogrammer
Bump version: 3.9.54 → 3.9.55
777b840
@softwareengineerprogrammer
update unit test
e89a4e2
@softwareengineerprogrammer
Change output param name to 'Average Annual Royalty Cost'
4215254
@softwareengineerprogrammer
Fix incorrect method of setting royalties output param value
44d87d0
@softwareengineerprogrammer
Internally distinguish between SAM econ royalty cost time series and …
dab0994 
…main econ average annual value
@softwareengineerprogrammer
WIP - calculate Royalty Holder NPV
e898ea4
@softwareengineerprogrammer
assert royalty holder NPV
1ba8df4
@softwareengineerprogrammer
finish impl of royalty holder outputs
4f53b33
@softwareengineerprogrammer
Update documentation. Throw exception if royalty rate provided for no…
3ded083 
…n-SAM-EM inputs
@softwareengineerprogrammer
SAM-EM royalties documentation (parameter mapping + dedicated section)
281a74b
@softwareengineerprogrammer
Bump version: 3.9.55 → 3.9.56
cfbf614
@softwareengineerprogrammer
Move royalty outputs to EXTENDED ECONOMICS
7ced29b
@softwareengineerprogrammer
Outputs py38 future annotations
890748b
@softwareengineerprogrammer
Royalty escalation rate + max (WIP to add unit tests, implement full …
580e384 
…schedule support)
@softwareengineerprogrammer
Mark TODO support custom royalty rate schedule as a list parameter
46eb832
@softwareengineerprogrammer
test_royalty_rate_schedule
39213f1
@softwareengineerprogrammer
move logic to Economics.get_royalty_rate_schedule
291898d
@softwareengineerprogrammer
test_royalty_rate_escalation
bb37109
@softwareengineerprogrammer
Regenerate schema
ee1efe8
@softwareengineerprogrammer
Update SAM-EM Royalties docs
f60bcac
@softwareengineerprogrammer
example_SAM-single-owner-PPA-4: 50 MWe with Royalties
7f2f9f3
@softwareengineerprogrammer
Bump version: 3.9.56 → 3.9.57
772a276
@softwareengineerprogrammer
Add example_SAM-single-owner-PPA-4 to README examples table
148b88c
@softwareengineerprogrammer softwareengineerprogrammer added the enhancement New feature or request label Sep 24, 2025
@softwareengineerprogrammer softwareengineerprogrammer mentioned this pull request Sep 24, 2025
Closed
11 tasks
@softwareengineerprogrammer softwareengineerprogrammer changed the title Royalties [v3.9.60] Royalties [v3.9.61] Sep 24, 2025
@softwareengineerprogrammer softwareengineerprogrammer merged commit d0548e6 into main Sep 24, 2025
35 of 36 checks passed
@softwareengineerprogrammer softwareengineerprogrammer mentioned this pull request Sep 24, 2025
Merged
2 tasks
@softwareengineerprogrammer softwareengineerprogrammer deleted the royalty-economics-3 branch October 5, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@softwareengineerprogrammer