Skip to content

GeophiresInputParameters enhancement + FCR sensitivity test #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 10, 2024
Merged

GeophiresInputParameters enhancement + FCR sensitivity test #24

merged 6 commits into from
May 10, 2024

Conversation

softwareengineerprogrammer
Copy link
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented May 10, 2024 •
edited
Loading

Support combining input file and params object in GeophiresInputParameters i.e.

GeophiresInputParameters(from_file_path=dummy_input_path, params={'Baz': 'Quux', 'Quuz': 2})

Adds unit test using combined file & params for FCR sensitivity per NREL#206 (comment)

@softwareengineerprogrammer softwareengineerprogrammer mentioned this pull request May 10, 2024
Closed
@softwareengineerprogrammer softwareengineerprogrammer marked this pull request as ready for review May 10, 2024 18:47
@softwareengineerprogrammer softwareengineerprogrammer changed the title GeophiresInputParameters enhancement GeophiresInputParameters enhancement + FCR sensitivity test May 10, 2024
@softwareengineerprogrammer softwareengineerprogrammer mentioned this pull request May 14, 2024
Merged
@softwareengineerprogrammer softwareengineerprogrammer deleted the geophires-input-parameters-enhancement branch May 15, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@softwareengineerprogrammer