Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow test on python 3.12 #3023

Merged
merged 6 commits into from
May 20, 2024
Merged

Conversation

crnkv
Copy link
Contributor

@crnkv crnkv commented May 18, 2024

should pass the checks now... setuptools needs to be upgraded for python 3.12 test to find the module

edit:
still cannot pass unittest... but anyway, failures seemed to be merely network issues...

plus, one may consider migrate from make test python3 setup.py test unittest to the modern way pytest tests (start by having two ways of test in workflow yaml), see 1, 2

@crnkv crnkv changed the title Fix installation (python <= 3.11) and add workflow test on 3.12 Add workflow test on python 3.12 May 19, 2024
@soimort soimort merged commit e760fc5 into soimort:develop May 20, 2024
0 of 8 checks passed
@soimort
Copy link
Owner

soimort commented May 20, 2024

Thanks -- The failure was due to some unfixed extractors which are irrelevant to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants