Skip to content

Conversation

DogukanGun
Copy link

  • Add Transfer Sol example for poseidon
  • Add test case for example

@heyAyushh heyAyushh added contribute:poseidon Adds a poseidon example contribution to the repository. transfer-sol basics/transfrer-sol labels Nov 5, 2024
Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

@DogukanGun
Copy link
Author

5. cargo clippy

Hi @heyAyushh , thank you for the review. Branch is updated according to your comment.

@DogukanGun DogukanGun requested a review from heyAyushh November 25, 2024 07:28
@heyAyushh heyAyushh closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute:poseidon Adds a poseidon example contribution to the repository. transfer-sol basics/transfrer-sol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants