Skip to content

Conversation

valentinmadrid
Copy link
Collaborator

No description provided.

@valentinmadrid
Copy link
Collaborator Author

A good way of doing checks is finally done. These github actions can be ran once a month and build every program in this repository. Cost wise, I think we are staying below the GitHub actions free tier 1000 minutes per month, which is good.
Here is how it works:

  • For every action(every framework has a different action), the necessary dependencies get installed.
  • Then a loop gets created to build each program one after the other.
  • If there is any issue, the build fails and the maintainers get notified

@valentinmadrid
Copy link
Collaborator Author

To-do now is fixing all of the issues that are encountered when running these workflows: #34

#"basics/rent/anchor"
#"basics/repository-layout/anchor"
#"basics/transfer-sol/anchor"
#!!!!"compression/cnft-vault/anchor"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclamation points? !!!!?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You came at the wrong moment lol, I was doing a workaround as my fixes aren't merged yet. I'll let you know again whenever you can merge. Also drafting pr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it said you requested my review

avm install latest
avm use latest
declare -a StringArray=(
#"basics/checking-accounts/anchor"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the hash marks necessary #?

sh -c "$(curl -sSfL https://release.solana.com/beta/install)"
export PATH="/home/runner/.local/share/solana/install/active_release/bin:$PATH"
solana -V
rustc -V
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is Rust installed here already?


- name: Install dependencies
run: |
sh -c "$(curl -sSfL https://release.solana.com/beta/install)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beta version or latest? Which would make more sense for the examples?

@valentinmadrid valentinmadrid merged commit ed2a00c into main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants