-
Notifications
You must be signed in to change notification settings - Fork 460
Change way of doing cicd #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A good way of doing checks is finally done. These github actions can be ran once a month and build every program in this repository. Cost wise, I think we are staying below the GitHub actions free tier 1000 minutes per month, which is good.
|
To-do now is fixing all of the issues that are encountered when running these workflows: #34 |
.github/workflows/anchor.yml
Outdated
#"basics/rent/anchor" | ||
#"basics/repository-layout/anchor" | ||
#"basics/transfer-sol/anchor" | ||
#!!!!"compression/cnft-vault/anchor" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exclamation points? !!!!
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You came at the wrong moment lol, I was doing a workaround as my fixes aren't merged yet. I'll let you know again whenever you can merge. Also drafting pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK it said you requested my review
.github/workflows/anchor.yml
Outdated
avm install latest | ||
avm use latest | ||
declare -a StringArray=( | ||
#"basics/checking-accounts/anchor" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the hash marks necessary #
?
sh -c "$(curl -sSfL https://release.solana.com/beta/install)" | ||
export PATH="/home/runner/.local/share/solana/install/active_release/bin:$PATH" | ||
solana -V | ||
rustc -V |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is Rust installed here already?
|
||
- name: Install dependencies | ||
run: | | ||
sh -c "$(curl -sSfL https://release.solana.com/beta/install)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beta version or latest? Which would make more sense for the examples?
No description provided.