Add option to disable ldabs* and ldind* instructions #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
requested changes
Jan 17, 2022
There was a problem hiding this comment.
I think it would make more sense to move these checks into https://github.com/solana-labs/rbpf/blob/main/src/verifier.rs
|
I have started moving the checks to the verifier, but then noticed this: https://github.com/solana-labs/solana/blob/aadf4b9b63e2e754c8e2b96ea1b852c9d622d9bd/programs/bpf_loader/src/lib.rs#L157 bpf_loader doesn't use the verifier and rightly so imo - it's an extra pass over all the instructions and seems to do very minimal verification anyway. |
alessandrod
force-pushed
the
disable-load
branch
from
ea9a33a
to
815b30d
Compare
|
The call to the verifier is separated to measure the time spent there (I guess): But the verification pass should definitively happen. |
Part of the SBF cleanup effort.
alessandrod
force-pushed
the
disable-load
branch
from
815b30d
to
03a8b4c
Compare
Lichtso
approved these changes
Feb 3, 2022
18 tasks
10 tasks
nvjle
pushed a commit
to anza-xyz/llvm-project
that referenced
this pull request
Dec 21, 2023
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jan 31, 2024
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte
added a commit
to anza-xyz/llvm-project
that referenced
this pull request
Feb 16, 2024
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jun 28, 2024
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte
added a commit
to anza-xyz/llvm-project
that referenced
this pull request
Aug 19, 2024
This PR addressed two more items in solana-labs/solana#34250. It removes the little endian byte swap instructions (solana-labs/rbpf#493) and the input buffers related instructions (solana-labs/rbpf#251).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the SBFv2 cleanup effort solana-labs/solana#20323