Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Disables little-endian byte swap instructions in SBPFv2 #493

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Jul 31, 2023

@Lichtso Lichtso requested a review from alessandrod July 31, 2023 10:54
@codecov-commenter
Copy link

Codecov Report

Merging #493 (7579ff3) into main (2fe4357) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files          23       23           
  Lines       10145    10149    +4     
=======================================
+ Hits         9095     9099    +4     
  Misses       1050     1050           
Files Changed Coverage Δ
src/elf.rs 87.41% <100.00%> (+0.02%) ⬆️
src/interpreter.rs 97.67% <100.00%> (ø)
src/jit.rs 92.50% <100.00%> (+<0.01%) ⬆️
src/verifier.rs 97.50% <100.00%> (ø)

Copy link

@alessandrod alessandrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a note that we don't have tests for the case where it's disabled. We probably don't need a test for each thing we're disabling, we could have one test_all_the_cruft_we_disabled_in_sbfv2 (not necessarily in this PR, just before we actually enable sbfv2)

@Lichtso Lichtso merged commit d56e0e1 into main Aug 3, 2023
23 checks passed
@Lichtso Lichtso deleted the refactor/disable_le_instructions branch August 3, 2023 17:18
@Lichtso Lichtso mentioned this pull request Nov 28, 2023
18 tasks
nvjle pushed a commit to anza-xyz/llvm-project that referenced this pull request Dec 21, 2023
This PR addressed two more items in solana-labs/solana#34250. 
It removes the little endian byte swap instructions (solana-labs/rbpf#493) 
and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte added a commit to LucasSte/llvm-project that referenced this pull request Jan 31, 2024
This PR addressed two more items in solana-labs/solana#34250.
It removes the little endian byte swap instructions (solana-labs/rbpf#493)
and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte added a commit to anza-xyz/llvm-project that referenced this pull request Feb 16, 2024
This PR addressed two more items in solana-labs/solana#34250.
It removes the little endian byte swap instructions (solana-labs/rbpf#493)
and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte added a commit to LucasSte/llvm-project that referenced this pull request Jun 28, 2024
This PR addressed two more items in solana-labs/solana#34250.
It removes the little endian byte swap instructions (solana-labs/rbpf#493)
and the input buffers related instructions (solana-labs/rbpf#251).
LucasSte added a commit to anza-xyz/llvm-project that referenced this pull request Aug 19, 2024
This PR addressed two more items in solana-labs/solana#34250.
It removes the little endian byte swap instructions (solana-labs/rbpf#493)
and the input buffers related instructions (solana-labs/rbpf#251).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants