Fix - LoadedProgramType::Closed #31922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
fix/loaded_program_type_closed
branch
from
13c20b6
to
037468f
Compare
Codecov Report
@@ Coverage Diff @@
## master #31922 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 762 762
Lines 207721 207669 -52
=========================================
- Hits 170137 170094 -43
+ Misses 37584 37575 -9 |
pgarg66
previously approved these changes
Jun 1, 2023
Lichtso
force-pushed
the
fix/loaded_program_type_closed
branch
2 times, most recently
from
bd60a0b
to
764dd93
Compare
Lichtso
force-pushed
the
fix/loaded_program_type_closed
branch
from
764dd93
to
e4ec4a3
Compare
pgarg66
approved these changes
Jun 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
* Makes Bank::load_program() return correct tombstones. * Removes early TX failure caused by closed and invalid programs. * Adjusts the feature gate of simplify_writable_program_account_check. (cherry picked from commit 3f13cd3) # Conflicts: # runtime/src/accounts.rs
Lichtso
added a commit
that referenced
this pull request
Jun 8, 2023
* Makes Bank::load_program() return correct tombstones. * Removes early TX failure caused by closed and invalid programs. * Adjusts the feature gate of simplify_writable_program_account_check. (cherry picked from commit 3f13cd3)
Lichtso
added a commit
that referenced
this pull request
Jun 8, 2023
Fix - LoadedProgramType::Closed (#31922) * Makes Bank::load_program() return correct tombstones. * Removes early TX failure caused by closed and invalid programs. * Adjusts the feature gate of simplify_writable_program_account_check. (cherry picked from commit 3f13cd3) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bank::replenish_program_cache()maps all error ofBank::load_program()toLoadedProgramType::FailedVerificationand never toLoadedProgramType::Closed. Also, the feature gate ofsimplify_writable_program_account_checkshould not includeLoadedProgramType::ClosedonlyLoadedProgramType::FailedVerification.Summary of Changes
Bank::load_program()return correct tombstones.simplify_writable_program_account_check.