-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not prune cache entry if the runtime environment is different #34100
Conversation
f4448b9
to
17a32e0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34100 +/- ##
==========================================
Coverage 81.8% 81.9%
==========================================
Files 766 819 +53
Lines 209158 220170 +11012
==========================================
+ Hits 171210 180430 +9220
- Misses 37948 39740 +1792 |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
) (cherry picked from commit 3368579)
) (cherry picked from commit 3368579)
Problem
LoadedPrograms::prune()
should not remove an old entry if the runtime environment has changed. The old entry could still be getting used to replay old slots (slots corresponding to the old environment).Summary of Changes
Check if the environment matches before pruning the old entry.
Fixes #