-
Notifications
You must be signed in to change notification settings - Fork 7
CloseStuckEscrow
instruction
#139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! Just the bit about the immutable owner extension
joncinque
reviewed
Jun 20, 2025
buffalojoec
reviewed
Jun 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second Jon's feedback, and added some inconsequential comments myself. 😊
joncinque
approved these changes
Jun 23, 2025
buffalojoec
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This instruction is a mitigation for an edge case. A mint with the close authority extension has the ability to:
1 - close the mint
2 - re-create the mint w/ new extensions
This can happen after an escrow ATA is created and whose owner is set to be the
WrappedMintAuthority
. Because the re-created mint adds new space/extension requirements to the escrow ATA, an attempt toWrap
will result in an error.The mitigation is this instruction which can detect the bad state of the escrow PDA and close it. The client can then re-create it on their own.