Transfer hook support #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
commented
Feb 27, 2025
grod220
commented
Feb 27, 2025
grod220
commented
Feb 27, 2025
buffalojoec
reviewed
Feb 28, 2025
grod220
force-pushed
the
transfer-hooks
branch
2 times, most recently
from
9df4636 to
d68d4f7
Compare
buffalojoec
reviewed
Mar 4, 2025
Merged
joncinque
reviewed
Mar 5, 2025
joncinque
reviewed
Mar 6, 2025
joncinque
approved these changes
Mar 6, 2025
buffalojoec
approved these changes
Mar 6, 2025
| "private": true, | ||
| "scripts": { | ||
| "programs:build": "zx ./scripts/rust/build-sbf.mjs program", | ||
| "programs:build": "cargo-build-sbf", |
There was a problem hiding this comment.
Yikes. I saw the discussion on this earlier, so I'm not going to make a stink here, but here's another situation where our CI is getting out of whack. Not your fault or within the scope of this PR, so you can disregard my griping. 🥴
There was a problem hiding this comment.
Yeah... we should eventually pool all the updates to https://github.com/solana-program/create-solana-program and then update all the repos from that for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the mint has support for the TransferHooks extension, the program will now execute them upon a wrap or unwrap action.
Makes use of helpers exposed by token-2022 repo. However, there is a dependency on solana-program/token-2022#233 for multisig support.
New
test-transfer-hookprogram created to test out new functionality.