Sync metadata to token-2022 pt. 1 #221
Conversation
grod220
force-pushed
the
sync-metadata-token-2022-pt-1
branch
from
9e5e2df to
b0d4176
Compare
| fn pre_initialize_extensions( | ||
| wrapped_mint_account: &AccountInfo, | ||
| wrapped_token_program_account: &AccountInfo, | ||
| ) -> ProgramResult; | ||
|
|
||
| /// Customizes extensions for the wrapped mint *after* the base mint is | ||
| /// initialized. This is for extensions that require the mint to be | ||
| /// initialized, like `TokenMetadata`. | ||
| fn post_initialize_extensions<'a>( | ||
| wrapped_mint_account: &AccountInfo<'a>, | ||
| wrapped_token_program_account: &AccountInfo, | ||
| wrapped_mint_authority_account: &AccountInfo<'a>, | ||
| mint_authority_signer_seeds: &[&[u8]], | ||
| ) -> ProgramResult; |
There was a problem hiding this comment.
Simplifying this interface and removing the pre-post-mint-init pattern here (given we don't do anything post init in CreateMint anymore)
| invoke_signed( | ||
| &initialize_token_metadata( | ||
| wrapped_token_program_account.key, | ||
| wrapped_mint_account.key, | ||
| &wrapped_mint_authority, | ||
| wrapped_mint_account.key, | ||
| &wrapped_mint_authority, | ||
| // Initialized as empty, but separate instructions are available | ||
| // to update these fields | ||
| "".to_string(), | ||
| "".to_string(), | ||
| "".to_string(), | ||
| ), | ||
| &cpi_accounts, | ||
| &[mint_authority_signer_seeds], | ||
| )?; |
There was a problem hiding this comment.
Removing this saves rent on those wrapped mints without unwrapped mint metadata
| /// Calculate the exact mint account length including all extensions | ||
| pub fn calc_mint_len(mint_key: &Pubkey, extensions: &[MintExtension]) -> usize { |
There was a problem hiding this comment.
Even though this is just for tests, went a bit down the rabbit hole trying to understand exactly how to calculate space for multiple scenarios:
- no extensions
- only fixed extensions
- only variable extensions
- mixed
Maybe there is some util I am missing, but this was not easy. Eventually this will be used in the cli/client code.
| check-cfg = [ | ||
| 'cfg(target_os, values("solana"))', | ||
| 'cfg(feature, values("frozen-abi", "no-entrypoint"))', | ||
| 'cfg(feature, values("custom-heap", "custom-panic"))', |
There was a problem hiding this comment.
New lint warnings require this
grod220
force-pushed
the
sync-metadata-token-2022-pt-1
branch
from
b0d4176 to
db6a1b9
Compare
| Ok(()) | ||
| } | ||
|
|
||
| type FieldExtractor = Vec<(Field, fn(&TokenMetadata) -> &str)>; |
There was a problem hiding this comment.
nit: this might have changed since I last worked on stuff like this, but function pointers tend to be less performant than closures because the compiler will never inline the code, so typically, Fn is much better than fn
There was a problem hiding this comment.
The challenge is that, for Fn, putting multiple extractors in a vec requires a trait object like Box<dyn Fn(..)> which is not inlineable either. If we really want to inline this though, we can revert the update_fields_if_changed() helper entirely and just do the checks one-after-the-other (prior).
There was a problem hiding this comment.
Ah right, I forgot about that part, sorry. Never mind then, probably easiest to stick to a function pointer then.
Adds
SyncMetadataToToken2022instruction to syncTokenMetadatafrom an unwrapped Token-2022 mint (later will be adding spl-token) to its wrapped Token-2022 mint. Initializes if missing, otherwise updates only changed fields and removes stale additional_metadata keys.CreateMintno longer initializesTokenMetadata. This is a follow up from Add metadata extensions onCreateMint#208 (comment).MintCustomizer trait methods simplified further to only what is needed.