Update IDL + js clients #265
Conversation
| --- | ||
| "@solana-program/token-wrap": patch | ||
| --- | ||
|
|
||
| Update CreateMint helper to support token-2022 extension sizing |
There was a problem hiding this comment.
That's because we use git cliff on these program repos right? (Changeset is unfortunately JavaScript only).
There was a problem hiding this comment.
This update was due to a program change where extensions were added to the wrapped token-2022 versions. This required a new conditional: https://github.com/solana-program/token-wrap/blob/main/clients/js/src/create-mint.ts#L70-L72
There was a problem hiding this comment.
Okay no worries. I was not really questioning the content of the changeset but more why this repo is using changesets altogether when the other repos in the solana-program org are not. Not because it shouldn't but to understand if we should do the same on the other repos for consistency. I believe the other repos are using git cliff since it allows changelogs based on folders and not JS packages which is useful in a multi-language repo. This is out of scope for this PR anyway but I was curious.
There was a problem hiding this comment.
Oh! I used Kit as inspiration for using changesets and assumed it was the standard across the board for web projects at anza. My bad, didn't realize this. It doesn't feel urgent to fix now, but will definitely revisit this.
A follow up to #262
Updates the IDL to support newly added instructions:
SyncMetadataToSplToken&SyncMetadataToToken2022.