-
Notifications
You must be signed in to change notification settings - Fork 7
CLI: Wrap multisig support #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6f85ea4
to
59b308c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! Just some small questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be in-step with the linked reference example, so looking good to me. Just small stuff.
59b308c
to
4db885c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enables offline multisig signature collection for the
Wrap
command. API inspiration: https://solana-program-docs.vercel.app/docs/token#example-offline-signing-with-multisig.Requires a multi-step process in collecting signatures & then broadcasting.
Walkthrough for testing locally:
Keep this running in a separate terminal.
Save the result in a local var
Save the account result in a local var
Mint tokens to the multisig-owned account
token-wrap
command (saving results to varsSave result to vars
spl-token create-account $WRAPPED_MINT --program-id TokenzQdBNbLqP5VEhdkAS6EPFLC1PHnBqCXEpPxuEb
Save result to vars