JS helper: Unwrap #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
grod220
force-pushed
the
js-client-wrap-multisig
branch
2 times, most recently
from
a740634 to
63fb236
Compare
grod220
force-pushed
the
js-client-unwrap
branch
from
a95f5e8 to
c6fcb5f
Compare
grod220
force-pushed
the
js-client-unwrap
branch
from
c6fcb5f to
f586c2b
Compare
grod220
commented
Apr 23, 2025
| } | ||
| return getTokenDecoder().decode(account.data).mint; | ||
| } | ||
|
|
There was a problem hiding this comment.
Everything below this comment was moved from src/wrap.ts given combinedMultisigTx is a shared function between both wrap and unwrap helpers.
mcintyre94
approved these changes
Apr 24, 2025
Comment on lines
+20
to
+36
| export interface SingleSignerUnwrapArgs { | ||
| rpc: Rpc<GetAccountInfoApi>; | ||
| blockhash: { | ||
| blockhash: Blockhash; | ||
| lastValidBlockHeight: bigint; | ||
| }; | ||
| payer: TransactionSigner; // Fee payer and default transfer authority | ||
| wrappedTokenAccount: Address; | ||
| unwrappedEscrow: Address; | ||
| amount: bigint | number; | ||
| recipientUnwrappedToken: Address; | ||
| // Optional arguments below (will be derived/defaulted if not provided) | ||
| transferAuthority?: Address | TransactionSigner; // Defaults to payer | ||
| unwrappedMint?: Address; // Will derive from unwrappedEscrow if not provided | ||
| wrappedTokenProgram?: Address; // Will derive from wrappedTokenAccount if not provided | ||
| unwrappedTokenProgram?: Address; // Will derive from unwrappedEscrow if not provided | ||
| } |
There was a problem hiding this comment.
Optional for a follow up PR - it might be worth using TSDoc here: https://tsdoc.org
The benefit would be that this param documentation will show inline in the editor for someone creating this, while these comments typically won't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final javascript helper for the Token Wrap program. Mirrors the Rust work done in #47.
Logic largely follows Wrapping work: #53