-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #94
Comments
Hm, seems I broke something now - try: npm install
npm run build
cd dist
npx serve Then open http://localhost:5000/databrowser with your browser and open the developer console. |
It seems to be due to SolidOS/chat-pane#40 |
Should also include nodeSolidServer/solid-auth-client#150 |
Step 2Using the latest npm versions of:
I'm updating npm dependencies for:
|
Step 3 would be:
|
Current status: |
Full-stack build is successful in mashlib-dev now. |
I ran |
Hm, https://github.com/solid/solid-auth-tls was archived and not forked anywhere. See https://github.com/solid/solid-ui/issues/324 |
Also node-solid-ws, @solid/acl-check. |
Update complete and tests passing locally in mashlib-dev:
Exception: stayed on bootstrap@3 in NSS because it seems bootstrap@4 no longer ships fonts in |
Now running into nodeSolidServer/solid-auth-client#163 (comment), investigating. |
Note you need to comment out
in the .gitignore of mashlib-dev/workspaces/isomorphic-webcrypto, otherwise the build of for instance mashlib will fail with:
|
I should look into https://github.com/interop-alliance/oidc-rp / https://github.com/anvilresearch/oidc-rp / https://github.com/solid/oidc-rp situation, thanks @SharonStrats for pointing me to https://github.com/solid/oidc-rp#deprecation-notice ! CC @dmitrizagidulin |
Merged and published:
|
Will do the rest once I can publish https://www.npmjs.com/package/solid-auth-client. @jeff-zucker do you want to tag and publish versions of solid-cli, solid-rest and solid-auth-cli? I started updating those because I thought I needed them in the dependency tree, but in the end I was able to drop them thanks to linkeddata/rdflib.js#361. Btw, we should also do a dependency update for https://github.com/solid/data-kitchen, right? Do you want to work on that together? |
Done! :) |
I am just now seeing this message ... my github notifications must be fubared ... absolutely I want to work together on this ... I have recently made progress with the newest electron and mashlib in Data Kitchen ... I have no problem with removing solid-auth-cli from the rdflib dependency tree BUT I would like to see a way to easily substitute a different fetcher so that solid-rest can be used to fetch non-http requests. |
CC @jaxoncreed ^ |
@jaxoncreed and @michielbdejong - I m not sure which one of you I need to be talking with, could you clarify your respective roles in relation to rdflib/mashlib/SolidOS? I'd like chat/zoom with one or both of you when you are available. My issues in relation to Data Kitchen and other uses of rdflib/mashlib outside a standard browser context: 1) how to plan for transition from solid-auth-cli to solid-client-authn. 2) How to use an alternate fetch if default_fetcher is removed. 3) whether solid-rest should remain a dependency even when solid-cli and solid-auth-cli are removed. @michielbdejong - I also would like to talk with you about using the crud tests (and other parts of the test suite) against file:// URIs - AFAIK solid-rest should be able to pass most or all of the tests other than ACL related things. |
My role is purely ad-hoc and volunteering, nobody is paying me to maintain these libraries. I think Jackson is in mostly the same position. If you have fixed something then if it works for you and doesn't break the tests, and it feels like the right change to make, then it's probably good to merge.
re crud tests against file:/// yeah, go for it! You can fork the solid-crud-tests repo and replace all the lines where is uses solid-auth-fetcher, like |
Thanks @michielbdejong, I've more or less figured these things out since posting, but it helps to have confirmation. I also work adhoc as a volunteer so really appreciate all the work you both have put in. As it turns out, once we add global.solidFetcher in addition to window.solidFetcher (which isn't available in nodejs, see my PR #464) it is indeed easy to sub in an alternate fetcher in rdflib. In terms of the future changes, I believe in supporting what works now while also keeping as open to what might change as possible. I'm releasing a new solid-node-client that does this by giving the user a choice as to whether they want solid-auth-fetcher or solid-client-authn-node or something else as the auth fetcher. I am hoping for a flexible plugin architecture that supports users bringing their own just about everything. I am currently running into a snag with that in that if I import both solid-auth-fetcher and solid-client-authn-node in the same process, they clobber each other somehow. Must dig! But I have it working that user can use either one, just not both. As soon as I have time (yeah, right!) I'll dig into the crud-tests. In terms of dependencies, I am now on to trying to figure out how to include data-kitchen in Solidos. Mashlib, panes, and solid-ui are so integral to data-kitchen that it makes sense to have it live connected inside SolidOS. For now I am doing manual npm linking but it will be nice to eventually have it within the amazing generation framework you have built. Data-kitchen is not as ready for prime time as the other parts of SolidOS, so politically, I am not sure when is the right time to include it. Would value your thoughts. |
@jeff-zucker You can include data-kitchen at the end of https://github.com/solid/solidos/blob/master/scripts/release so that it gets built with the latest dependencies whenever someone runs that script. For that, it doesn't need to be read for prime time, as long as the build doesn't error. |
Step 1
Using the latest npm versions of:
I'm updating npm dependencies for:
The text was updated successfully, but these errors were encountered: